-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Food Cart #20544
base: master
Are you sure you want to change the base?
Food Cart #20544
Conversation
alsoandanswer
commented
Mar 2, 2025
•
edited
Loading
edited
- rscadd: "Adds a new food cart to the kitchen."
- bugfix: "Fixes grill and oven to play their loop sounds only when turned on."
- bugfix: "Fixes update_icon() of grill and oven so they actually look turned on when turned on."

!review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehh, really not a fan of this
It's just silly and gamey how a single tiny "food cart" unpacks into a 3x2 tile structure like this with a food heater and grill. It doesn't look like a single food card either when unpacked, cause the grill/table/heater sprites are unchanged from normal
And reading the code it looks like it still uses power, so it can't really be used for odyssey or random exoplanets, so there's not much point in this
--
I would very much prefer portable kitchen appliances that:
- do not use power (running on batteries or even wood, so they can be used anywhere, without engineers needing to set up power)
- and with no unpacking mechanics (we already have folding tables and chairs that are easy to pack up and unpack)
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
I'd concur but this is just a quick port from /tg/. Maybe in a different PR |
var/unpacked = FALSE // When it's anchored and has all it's things outside | ||
var/obj/machinery/appliance/cooker/grill/stand/cart_griddle // Griddle inside of the foodcart | ||
var/obj/machinery/smartfridge/foodheater/stand/cart_smartfridge // Smartfridge inside of foodcart | ||
var/obj/structure/table/reinforced/wood/cart_table // Table inside of foodcart | ||
var/obj/effect/food_cart_stand/cart_tent // Overlay that spawns once foodcart is setup | ||
var/list/packed_things // Contains cart_griddle, cart_smartfridge, cart_table, cart_cent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these are a DMDoc
https://github.com/Aurorastation/Aurora.3/blob/master/.github/guides/STYLE.md#how-to-document
* * has_space - sets to FALSE if any turf in build area has density = TRUE | ||
* * grabbed_turf - starts one tile SOUTH of cart, then sequentially checks one tile EAST | ||
* * cart_space - temporary overlay showing non-dense and dense tiles checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??? None of these is even a parameter of this proc, which takes no parameter
* * iteration - counter for how many items have been unpacked, increment for each item unpacked | ||
* * cart_space - temporary overlay showing non-dense and dense tiles checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these is a parameter of this proc
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>